feat(manager): add new contact form #1996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
server_manager/web_app/ui_components/outline-contact-us-dialog.ts
Outdated
Show resolved
Hide resolved
server_manager/web_app/ui_components/outline-contact-us-dialog.ts
Outdated
Show resolved
Hide resolved
server_manager/web_app/ui_components/outline-contact-us-dialog.ts
Outdated
Show resolved
Hide resolved
|
I wasn't sure if I should approve - I'm not crazy about the hacks we're having to do. Just address what you think you can/want to and we should be good. |
Most of this code was a copy from the client form, if that helps. I just wrapped it in a dialog and made minor edits. |
daniellacosse
approved these changes
Apr 25, 2024
sbruens
force-pushed
the
sbruens/manager-contact
branch
2 times, most recently
from
f44f0ef
to
ceb7b23
Compare
sbruens
force-pushed
the
sbruens/manager-contact
branch
from
ceb7b23
to
4798a4f
Compare
sbruens
force-pushed
the
sbruens/manager-contact
branch
from
c4a9f42
to
1ad1412
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is still behind a flag for now and disabled, while we sort out copying over existing translations.