Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: run npm clean across packages #1978

Merged
merged 2 commits into from
Apr 19, 2024
Merged

chore: run npm clean across packages #1978

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
470b479
chore: run npm clean across workspaces
daniellacosse Apr 17, 2024
1ad8efc
Merge branch 'master' into daniellacosse/improved_clean
daniellacosse Apr 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions client/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,5 +143,8 @@
"ios",
"osx"
]
},
"scripts": {
"clean": "rm -rf build output node_modules www platforms plugins"
}
}
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
"action:help": "npm run action list",
"action:list": "npm run action list",
"action": "node ./src/build/run_action.mjs",
"clean": "rimraf client/build client/output node_modules client/node_modules client/www client/platforms client/plugins third_party/jsign/*.jar && go run github.com/go-task/task/v3/cmd/task clean",
"clean": "npm run clean --workspaces && rm -rf output node_modules third_party/jsign/*.jar && go run github.com/go-task/task/v3/cmd/task clean",
"format:all": "prettier --write \"**/*.{cjs,mjs,html,js,json,md,ts}\"",
"format": "pretty-quick --staged --pattern \"**/*.{cjs,mjs,html,js,json,md,ts}\"",
"lint:ts": "eslint --ext ts,mjs client/src",
Expand Down
5 changes: 4 additions & 1 deletion server_manager/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,5 +110,8 @@
"supports-color": "3.1.2",
"type-detect": "1.0.0"
},
"license": "Apache"
"license": "Apache",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is not the right designation. It may be Apache-2? Also, do we need it on every package.json?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think so, I can remove it in a license cleanup.

"scripts": {
"clean": "rm -rf node_modules install_scripts/do_install_script.ts install_scripts/gcp_install_script.ts"
}
}
Loading