chore(client): move outline/device and rename tun2socks to backend
#1962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daniellacosse
changed the title
client/src/tun2socks to client/src/backend and move outline/device to client/src/backend/outline/deviceclient/src/tun2socks to client/src/backend and move outline/device to client/src/backend/outline/device
daniellacosse
changed the title
client/src/tun2socks to client/src/backend and move outline/device to client/src/backend/outline/deviceoutline/device and rename tun2socks to backend
daniellacosse
commented
Apr 8, 2024
| @@ -11,7 +11,7 @@ IMPORT_PATH=$(IMPORT_HOST)/Jigsaw-Code/outline-apps | |||
|
|
|||
There was a problem hiding this comment.
Can move the Makefile in another PR
jyyi1
reviewed
Apr 8, 2024
| @@ -37,7 +37,7 @@ $(BUILDDIR)/apple/Tun2socks.xcframework: $(BUILDDIR)/ios/Tun2socks.xcframework $ | |||
| XGO=$(GOBIN)/xgo | |||
| TUN2SOCKS_VERSION=v1.16.11 | |||
| XGO_LDFLAGS='-w -X main.version=$(TUN2SOCKS_VERSION)' | |||
| ELECTRON_PKG="./client/src/tun2socks/outline/electron" | |||
| ELECTRON_PKG="./client/src/backend/outline/electron" | |||
There was a problem hiding this comment.
Please double confirm this won't change the final binary name (it should be tun2socks for Linux and tun2socks.exe for Windows).
Or maybe we should actually update it to backend and backend.exe? It's up to you.
There was a problem hiding this comment.
We can do this in a later pr, I'm trying to minimize breakage.
I can't build tun2socks until @fortuna's pr fixing the xgo issue is merged. Do you mind confirming?
fortuna
requested changes
Apr 10, 2024
|
Closing this in favor of just deleting outline/device |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that this blocks the removal of
client/src