Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "fix(cordova/apple/ios): add app icons for mac catalyst" #1939

Merged
merged 1 commit into from
Apr 1, 2024

Conversation

daniellacosse
Copy link
Contributor

@daniellacosse daniellacosse commented Mar 29, 2024

Reverts #1792

This broke our ability to upload the iOS app to Testflight.

Copy link

codecov bot commented Mar 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 32%. Comparing base (e32363a) to head (a240f78).

Additional details and impacted files
@@           Coverage Diff            @@
##           master   #1939     +/-   ##
========================================
+ Coverage      15%     32%    +17%     
========================================
  Files           6      45     +39     
  Lines         804    2620   +1816     
  Branches        0     340    +340     
========================================
+ Hits          121     860    +739     
- Misses        683    1760   +1077     
Flag Coverage Δ
apple 15% <ø> (ø)
ios 15% <ø> (ø)
maccatalyst 15% <ø> (ø)
macos 15% <ø> (ø)
unittests 32% <ø> (+17%) ⬆️
www 40% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@daniellacosse daniellacosse marked this pull request as ready for review March 29, 2024 19:48
@daniellacosse daniellacosse requested a review from a team as a code owner March 29, 2024 19:48
@daniellacosse daniellacosse merged commit dea1ca1 into master Apr 1, 2024
27 checks passed
@daniellacosse daniellacosse deleted the revert-1792-sbruens/catalyst-icons branch April 1, 2024 12:12
daniellacosse added a commit that referenced this pull request Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants