chore: normalize all line endings in the repository #1913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1913 +/- ##
======================================
Coverage 32% 32%
======================================
Files 45 45
Lines 2610 2610
Branches 337 337
======================================
Hits 859 859
Misses 1751 1751
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
jyyi1
approved these changes
Feb 28, 2024
I just double-checked and I don't think this change affects licensing. |
This was referenced Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran
git add --renormalize .on the repo, see https://git-scm.com/docs/git-add#Documentation/git-add.txt---renormalize. This is a safe way to normalize all line endings, changing files that have been committed with CLRF to LF.Copybara does this when copying translation files: 2a544a8. Doing a one-time fix like this separately will make the Copybara copy commits cleaner.