Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(www): launch the new webform #1843

Merged
merged 4 commits into from
Feb 29, 2024
Merged

feat(www): launch the new webform #1843

merged 4 commits into from
Feb 29, 2024

Conversation

sbruens
Copy link
Contributor

@sbruens sbruens commented Feb 21, 2024

Merge once Jigsaw-Code/outline-server#1510 has landed.

Copy link

codecov bot commented Feb 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 40%. Comparing base (fad9ae2) to head (2966690).

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #1843   +/-   ##
======================================
  Coverage      40%     40%           
======================================
  Files          39      39           
  Lines        1806    1806           
  Branches      337     337           
======================================
  Hits          738     738           
  Misses       1068    1068           
Flag Coverage Δ
unittests 40% <ø> (ø)
www 40% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sbruens sbruens marked this pull request as ready for review February 22, 2024 18:40
@sbruens sbruens requested a review from a team as a code owner February 22, 2024 18:40
Copy link
Contributor

@jyyi1 jyyi1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM. I have a question regarding future maintenance, do we need to delete these feature flags in the future ? Or do we just keep them in the code base forever?

@sbruens
Copy link
Contributor Author

sbruens commented Feb 23, 2024

Code LGTM. I have a question regarding future maintenance, do we need to delete these feature flags in the future ? Or do we just keep them in the code base forever?

Yeah we should delete them. This will just allow an easy launch and a quick rollback path. Once it's landed we should delete the flag and the old components.

@sbruens
Copy link
Contributor Author

sbruens commented Feb 28, 2024

Jigsaw-Code/outline-server#1510 was pushed to production. This can be merged.

@sbruens sbruens merged commit 8db4ec9 into master Feb 29, 2024
22 checks passed
@sbruens sbruens deleted the sbruens/launch-form branch February 29, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants