-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(manager): move the manager and rename the repository to outline_apps
#1834
Merged
Merged
Changes from 14 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
b510c6c
chore(manager): move the manager
daniellacosse af31468
fix commit message, redunant task names, and replace run_action with …
daniellacosse a9e9834
differentiate concurrency groups
daniellacosse 23a0012
works up to the build - need to more carefully merge package jsons
daniellacosse 5ad6c9b
try THIS
daniellacosse db25255
we don't... need this?
daniellacosse f56cfe8
try to speed up npm?
daniellacosse 8f42fbd
build windows on linux
daniellacosse c51d52a
that no worky lol
daniellacosse 616964e
try npm set cache
daniellacosse 39836ea
remove --prod :/
daniellacosse 753e772
prefer offline
daniellacosse 7368428
clean up
daniellacosse e440fa1
eh, nah
daniellacosse b7fb05a
make install scripts more specific
daniellacosse File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,129 @@ | ||
| name: Build and Test / Manager | ||
|
|
||
| concurrency: | ||
| group: '${{ github.head_ref || github.ref }} Manager' | ||
| cancel-in-progress: true | ||
|
|
||
| on: | ||
| pull_request: | ||
| types: | ||
| - opened | ||
| - synchronize | ||
| push: | ||
| branches: | ||
| - master | ||
|
|
||
| jobs: | ||
| lint: | ||
| name: Lint | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Checkout | ||
| uses: actions/[email protected] | ||
|
|
||
| - name: Install Node | ||
| uses: actions/setup-node@v3 | ||
| with: | ||
| node-version-file: .nvmrc | ||
| cache: npm | ||
| cache-dependency-path: ./server_manager/package.json | ||
|
|
||
| - name: Install NPM Dependencies | ||
| run: npm ci | ||
|
|
||
| - name: Lint | ||
| run: npm run lint | ||
|
|
||
| web_test: | ||
| name: Web Test | ||
| runs-on: ubuntu-latest | ||
| needs: lint | ||
| steps: | ||
| - name: Checkout | ||
| uses: actions/[email protected] | ||
|
|
||
| - name: Install Node | ||
| uses: actions/setup-node@v3 | ||
| with: | ||
| node-version-file: .nvmrc | ||
| cache: npm | ||
| cache-dependency-path: ./server_manager/package.json | ||
|
|
||
| - name: Install NPM Dependencies | ||
| run: npm ci | ||
|
|
||
| - name: Manager Web Test | ||
| run: npm run action server_manager/test | ||
|
|
||
| linux_debug_build: | ||
| name: Linux Debug Build | ||
| runs-on: ubuntu-latest | ||
| needs: web_test | ||
| env: | ||
| SENTRY_DSN: debug | ||
| steps: | ||
| - name: Checkout | ||
| uses: actions/[email protected] | ||
|
|
||
| - name: Install Node | ||
| uses: actions/setup-node@v3 | ||
| with: | ||
| node-version-file: .nvmrc | ||
| cache: npm | ||
| cache-dependency-path: ./server_manager/package.json | ||
|
|
||
| - name: Install NPM Dependencies | ||
| run: npm ci | ||
|
|
||
| - name: Build Linux Manager | ||
| run: npm run action server_manager/electron_app/build linux | ||
|
|
||
| windows_debug_build: | ||
| name: Windows Debug Build | ||
| # TODO(daniellacosse): port bash scripts to windows so we can build the manager on windows | ||
| runs-on: ubuntu-latest | ||
| needs: web_test | ||
| env: | ||
| SENTRY_DSN: debug | ||
| steps: | ||
| - name: Checkout | ||
| uses: actions/[email protected] | ||
|
|
||
| - name: Install Node | ||
| uses: actions/setup-node@v3 | ||
| with: | ||
| node-version-file: .nvmrc | ||
| cache: npm | ||
| cache-dependency-path: ./server_manager/package.json | ||
|
|
||
| - name: Install NPM Dependencies | ||
| run: npm ci | ||
|
|
||
| - name: Build Windows Manager | ||
| run: npm run action server_manager/electron_app/build windows | ||
|
|
||
| mac_debug_build: | ||
| name: MacOS Debug Build | ||
| runs-on: macos-11 | ||
| needs: web_test | ||
| env: | ||
| SENTRY_DSN: debug | ||
| steps: | ||
| - name: Checkout | ||
| uses: actions/[email protected] | ||
|
|
||
| - name: Install Node | ||
| uses: actions/setup-node@v3 | ||
| with: | ||
| node-version-file: .nvmrc | ||
| cache: npm | ||
| cache-dependency-path: ./server_manager/package.json | ||
|
|
||
| - name: Install NPM Dependencies | ||
| run: npm ci | ||
|
|
||
| - name: Set XCode Version | ||
| run: sudo xcode-select -switch /Applications/Xcode_13.2.app | ||
|
|
||
| - name: Build MacOS Manager | ||
| run: npm run action server_manager/electron_app/build macos |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this in the root?
I'd rather keep the .gitignore localized in the respective folder. Create the file there instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if you omit the slash, it ignores anything called
do_install_script.ts- I'll make it more specificThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please create a .gitignore in the directory where do_install_script.ts is created, so it's localized there.
I'd say same for
/server_managerto ignore the node_modules.It's easier to manage these if they are in context.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, I prefer that, even