fix(www): don't try to build tun2socks when developing for the browser #1833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fortuna
requested changes
Feb 5, 2024
Makefile
Outdated
| @@ -35,6 +35,9 @@ $(BUILDDIR)/apple/Tun2socks.xcframework: $(BUILDDIR)/ios/Tun2socks.xcframework $ | |||
| find $^ -name "Tun2socks.framework" -type d | xargs -I {} echo " -framework {} " | \ | |||
| xargs xcrun xcodebuild -create-xcframework -output "$@" | |||
|
|
|||
| browser: | |||
There was a problem hiding this comment.
Let's skip in https://github.com/Jigsaw-Code/outline-client/blob/master/src/tun2socks/build.action.mjs instead, so it doesn't even reach the make step and the per-platform dispatching is centralized in one place.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1833 +/- ##
======================================
Coverage 40% 40%
======================================
Files 39 39
Lines 1805 1805
Branches 337 337
======================================
Hits 738 738
Misses 1067 1067
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
fortuna
approved these changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.