Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cordova/apple/macos): correct app groups for catalyst #1811

Merged
merged 1 commit into from
Jan 2, 2024

Conversation

sbruens
Copy link
Contributor

@sbruens sbruens commented Jan 2, 2024

The location of the logs directory is specified by the provided App Group ID. This needs to match the app group so the VpnExtension can write log files for Sentry.

@sbruens sbruens requested a review from a team as a code owner January 2, 2024 17:32
@sbruens sbruens requested a review from fortuna January 2, 2024 17:32
Copy link

codecov bot commented Jan 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (70d4b77) 32% compared to head (d7e5035) 32%.

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #1811   +/-   ##
======================================
  Coverage      32%     32%           
======================================
  Files          45      45           
  Lines        2609    2609           
  Branches      337     337           
======================================
  Hits          859     859           
  Misses       1750    1750           
Flag Coverage Δ
apple 15% <ø> (ø)
ios 15% <ø> (ø)
maccatalyst 15% <ø> (ø)
macos 15% <ø> (ø)
unittests 32% <ø> (ø)
www 40% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sbruens sbruens merged commit 4c5b8bd into master Jan 2, 2024
17 checks passed
@sbruens sbruens deleted the sbruens/catalyst branch January 2, 2024 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants