Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(www): use querySelector now that element is dynamically created #1742

Merged
merged 1 commit into from
Oct 4, 2023
Merged

fix(www): use querySelector now that element is dynamically created #1742

merged 1 commit into from
Oct 4, 2023

Conversation

sbruens
Copy link
Contributor

@sbruens sbruens commented Oct 4, 2023

Nodes created dynamically (e.g. inside a dom-if template) are not added to the this.$ hash.

@sbruens sbruens requested a review from a team as a code owner October 4, 2023 20:01
@codecov
Copy link

codecov bot commented Oct 4, 2023 •
edited
Loading

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Files Coverage Δ
src/www/app/app.ts 8% <0%> (ø)

📢 Thoughts on this report? Let us know!.

@sbruens sbruens merged commit 813fbba into master Oct 4, 2023
16 of 17 checks passed
@sbruens sbruens deleted the sbruens/fix-feedback branch October 4, 2023 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniellacosse daniellacosse daniellacosse approved these changes

Assignees
No one assigned
Labels
size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sbruens @daniellacosse