chore(www): add a --watch flag for local test debugging
#1712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch has no changes to coverable lines. 📢 Thoughts on this report? Let us know!. |
src/www/test.action.mjs
Outdated
| * @param {string[]} parameters The list of action arguments passed in. | ||
| * @returns {Object} Object containing whether to run as part of CI. | ||
| */ | ||
| function getActionParameters(cliArguments) { |
There was a problem hiding this comment.
nit: I kinda feel like this function just adds indirection without much benefit
There was a problem hiding this comment.
Fair point. I mostly did this to keep it consistent with some of the other scripts I saw using this type of helper function. Removing it.
There was a problem hiding this comment.
In those cases the helper functions are shared across actions
sbruens
force-pushed
the
sbruens/test-dev
branch
from
41ddfe5
to
e399bde
Compare
Done. Went with the |
sbruens
changed the title
--ci flag for single runs--watch flag for local test debugging
sbruens
force-pushed
the
sbruens/test-dev
branch
from
e399bde
to
d6dd6a4
Compare
daniellacosse
approved these changes
Sep 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now when running
npm run action www/testyou get a single run by default, which is useful for CI workflows. I'm adding a--watchflag to help in debugging by keeping the server alive and re-running tests on changes.