Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(www): remove spec files from coverage analysis #1711

Merged
merged 1 commit into from
Sep 20, 2023

Conversation

sbruens
Copy link
Contributor

@sbruens sbruens commented Sep 15, 2023

No description provided.

@sbruens sbruens requested a review from a team as a code owner September 15, 2023 22:10
@codecov
Copy link

codecov bot commented Sep 15, 2023

Codecov Report

Patch has no changes to coverable lines.

📢 Thoughts on this report? Let us know!.

Copy link
Contributor

@jyyi1 jyyi1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks ! Will this PR resolve the code coverage issue? That would be very helpful.

use: ['@jsdevtools/coverage-istanbul-loader'],
test: /\.m?(t|j)s$/,
exclude: /(node_modules|\.spec\.m?(t|j)s$)/,
loader: '@jsdevtools/coverage-istanbul-loader',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the difference between use and loader?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use specifies an array of loaders with additional metadata: https://stackoverflow.com/questions/41750715/when-do-i-use-use-and-loader-in-webpack-2-module-rules

webpack's api is... omg so bad lmao

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is exactly the question I had yesterday and the accompanying SO article I found that made me use loader here.

@daniellacosse
Copy link
Contributor

Thanks ! Will this PR resolve the code coverage issue? That would be very helpful.

It won't, we have to configure codecov directly for that. But we shouldn't be collecting coverage from test files for sure

@sbruens sbruens requested a review from jyyi1 September 20, 2023 03:22
@sbruens sbruens merged commit 60777f3 into master Sep 20, 2023
15 of 16 checks passed
@sbruens sbruens deleted the sbruens/coverage branch September 20, 2023 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants