-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(www): remove spec files from coverage analysis #1711
Conversation
Codecov ReportPatch has no changes to coverable lines. 📢 Thoughts on this report? Let us know!. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks ! Will this PR resolve the code coverage issue? That would be very helpful.
use: ['@jsdevtools/coverage-istanbul-loader'], | ||
test: /\.m?(t|j)s$/, | ||
exclude: /(node_modules|\.spec\.m?(t|j)s$)/, | ||
loader: '@jsdevtools/coverage-istanbul-loader', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the difference between use
and loader
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use
specifies an array of loaders with additional metadata: https://stackoverflow.com/questions/41750715/when-do-i-use-use-and-loader-in-webpack-2-module-rules
webpack's api is... omg so bad lmao
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is exactly the question I had yesterday and the accompanying SO article I found that made me use loader
here.
It won't, we have to configure codecov directly for that. But we shouldn't be collecting coverage from test files for sure |
No description provided.