fix(electron/windows): 🩹 prevent command LPE in the installer #1703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #1703 +/- ##
=======================================
+ Coverage 36% 45% +8%
=======================================
Files 45 39 -6
Lines 2749 1943 -806
Branches 312 312
=======================================
- Hits 1006 885 -121
+ Misses 1743 1058 -685
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
fortuna
approved these changes
Aug 28, 2023
jyyi1
commented
Aug 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR tries to prevent the local privilege escalation issue in Outline Client Windows installer by specifying the full path of system commands. Note that in a
.batfile we can use%SystemRoot%variable (typically expands to "C:\Windows"), but it is not available in the.nshNSIS script, therefore we need to use the NSIS defined constant$SYSDIR(typically expands to "C:\Windows\System32").I also removed the Cygwin related information from the document because it is not required any more.
Fixes: b/266050099