Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(build): add maccatalyst as a build target #1701

Merged
merged 4 commits into from
Sep 25, 2023
Merged

Conversation

sbruens
Copy link
Contributor

@sbruens sbruens commented Aug 24, 2023

No description provided.

@sbruens sbruens requested a review from a team as a code owner August 24, 2023 14:24
@sbruens sbruens changed the title chore(build): Add maccatalyst as a build target. chore(build): add maccatalyst as a build target. Aug 24, 2023
@codecov
Copy link

codecov bot commented Aug 24, 2023

Codecov Report

Patch has no changes to coverable lines.

📢 Thoughts on this report? Let us know!.

@sbruens sbruens changed the title chore(build): add maccatalyst as a build target. chore(build): add maccatalyst as a build target Aug 24, 2023
Copy link
Contributor

@daniellacosse daniellacosse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose the idea is eventually maccatalyst will become macos once we're more confident?

@sbruens
Copy link
Contributor Author

sbruens commented Aug 24, 2023

I suppose the idea is eventually maccatalyst will become macos once we're more confident?

Yeah. We can rename when we remove all the old macos stuff.

@sbruens sbruens merged commit ac0723a into master Sep 25, 2023
17 checks passed
@sbruens sbruens deleted the sbruens/catalyst-build branch September 25, 2023 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants