Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(cordova/android): upgrade min target android API to 23 #1699

Merged
merged 4 commits into from
Aug 29, 2023
Merged

chore(cordova/android): upgrade min target android API to 23 #1699

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6379450
chore(cordova/android): upgrade min target android API to 33
daniellacosse Aug 18, 2023
81a3c93
Merge branch 'master' into daniellacosse/android_33
daniellacosse Aug 24, 2023
ded99dd
Update config.xml
daniellacosse Aug 24, 2023
7b28ae9
Merge branch 'master' into daniellacosse/android_33
daniellacosse Aug 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion config.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
<access origin="*" />
<allow-intent href="http://*/*" />
<allow-intent href="https://*/*" />
<preference name="android-minSdkVersion" value="22" />
<preference name="android-minSdkVersion" value="23" />
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need to upgrade, and what are the implications in user numbers?

Copy link
Contributor Author

@daniellacosse daniellacosse Aug 29, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's required by the Play Store!

Are you asking because you want it to be documented on this PR, or because you forgot about our email correspondence?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Too many things to track. I found the details, the deadline is August 31, 2023, so we have to do it anyway.

<preference name="android-targetSdkVersion" value="32" />
<preference name="AndroidLaunchMode" value="singleInstance" />
<preference name="ShowSplashScreenSpinner" value="false" />
Expand Down
Loading