Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE] convert to outline-apps repository, approach #1: single workspace #1692

Closed
wants to merge 3 commits into from

Conversation

daniellacosse
Copy link
Contributor

@daniellacosse daniellacosse commented Aug 9, 2023

This is proving to be about as annoying as I expected... with this approach, I'm trying to stick to only having one root NPM workspace. See Approach #2 for an alternative.

Tradeoffs:

  • Pro: One single NPM Workspace that's compatible with all the open source best practices and tooling we currently have out there
  • Pro: Less space on disk as all node dependencies will be deduped down into a single node_modules (or .yarn)
  • Pro: infrastructure can be very elegantly shared via things like
import { copyDir } from "@infrastructure/file";
  • Con: Lots of changes needed and realistically we'll probably need to do this in several medium-large chunks rather than massively all at once.
  • Con: Can only use one workspace toolchain and version of node at a time (can't use both npm workspaces and yarn workspaces)
  • Is there anything I'm not thinking of?

Current Issues:

  • do we need a root third_party folder?
  • do we need a root docs folder to preserve the invitation-instructions.md link?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like you need to delete the built stuff here

@daniellacosse daniellacosse changed the title [DO NOT MERGE] convert to outline-apps repository [DO NOT MERGE] convert to outline-apps repository, approach #1 Aug 10, 2023
@daniellacosse daniellacosse changed the title [DO NOT MERGE] convert to outline-apps repository, approach #1 [DO NOT MERGE] convert to outline-apps repository, approach #1: single workspace Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants