Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(cordova/apple): use standard folder naming in Swift package #1679

Merged
merged 1 commit into from
Jul 25, 2023

Conversation

fortuna
Copy link
Collaborator

@fortuna fortuna commented Jul 25, 2023

If the folder matches the target name, we don't need to specify the source path

@fortuna fortuna requested a review from sbruens July 25, 2023 19:47
@fortuna fortuna requested a review from a team as a code owner July 25, 2023 19:47
Copy link
Contributor

@sbruens sbruens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

@codecov
Copy link

codecov bot commented Jul 25, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (c908e1a) 36% compared to head (f163fc5) 36%.

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #1679   +/-   ##
======================================
  Coverage      36%     36%           
======================================
  Files          45      45           
  Lines        2756    2756           
  Branches      312     312           
======================================
  Hits         1006    1006           
  Misses       1750    1750           
Flag Coverage Δ
apple 14% <ø> (ø)
ios 15% <ø> (ø)
macos 14% <ø> (ø)
unittests 36% <ø> (ø)
www 45% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...AppleLib/Sources/OutlineTunnel/OutlineTunnel.swift 67% <ø> (ø)
...Lib/Sources/OutlineTunnel/OutlineTunnelStore.swift 29% <ø> (ø)
...ineAppleLib/Sources/OutlineTunnel/OutlineVpn.swift 0% <ø> (ø)
...OutlineAppleLib/Sources/OutlineTunnel/Subnet.swift 84% <ø> (ø)
...ources/PacketTunnelProvider/PacketTunnelProvider.m 0% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fortuna fortuna merged commit d7dc522 into master Jul 25, 2023
13 checks passed
@fortuna fortuna deleted the fortuna-clean branch July 25, 2023 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants