fix: change the help page url #1667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maddyhof
reviewed
Jul 18, 2023
src/www/ui_components/app-root.js
Outdated
| @@ -372,7 +372,7 @@ export class AppRoot extends mixinBehaviors([AppLocalizeBehavior], PolymerElemen | |||
| [[localize('about-page-title')]] | |||
| </paper-item> | |||
| <paper-item name="help"> | |||
| <a href="https://s3.amazonaws.com/outline-vpn/index.html#/support" id="helpAnchor" hidden=""></a> | |||
| <a href="https://getoutline.org/how-it-works" id="helpAnchor" hidden=""></a> | |||
There was a problem hiding this comment.
Let's switch it to https://support.getoutline.org instead, since that's a better destination for a user who's looking for help.
There was a problem hiding this comment.
Changed the link to the new one, sorry for long reply.
There was a problem hiding this comment.
We don't have an S3 mirror of the Support site, and AFAIK it hasn't gotten blocked, even when getoutline.org has (but correct me if I'm wrong).
maddyhof
requested changes
Jul 18, 2023
andreevgy
force-pushed
the
help-link-fix
branch
from
6c12f79
to
34fbda5
Compare
jyyi1
approved these changes
Aug 7, 2023
Codecov ReportPatch has no changes to coverable lines.
📢 Thoughts on this report? Let us know!. |
|
Thanks for the update, @andreevgy . Please sync the branch with the latest master branch before merge. Or we can do this for you if you prefer. |
andreevgy
force-pushed
the
help-link-fix
branch
from
34fbda5
to
6751ace
Compare
|
@jyyi1 just rebased it, should be good to go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello again!
Noticed that help link was not working for a while. Changed it to the working page on current website. Let me know if there should be something different.
P.S.: There is some issue with intl config on getoutline.org because it redirects me to
/intl/[lang]and show me this error