Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cordova/apple): improve Apple README #1665

Merged
merged 13 commits into from
Jul 19, 2023
Merged

chore(cordova/apple): improve Apple README #1665

merged 13 commits into from
Jul 19, 2023

Conversation

fortuna
Copy link
Collaborator

@fortuna fortuna commented Jul 14, 2023

No description provided.

@fortuna fortuna requested a review from a team as a code owner July 14, 2023 01:21
@fortuna
Copy link
Collaborator Author

fortuna commented Jul 14, 2023

@sbruens @jyyi1 FYI

@fortuna fortuna changed the title Improve Apple README chore(cordova/apple): improve Apple README Jul 14, 2023
@codecov
Copy link

codecov bot commented Jul 14, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (8c13f4d) 36% compared to head (4ac5a5e) 36%.

❗ Current head 4ac5a5e differs from pull request most recent head ea4ab3a. Consider uploading reports for the commit ea4ab3a to get more accurate results

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #1665   +/-   ##
======================================
  Coverage      36%     36%           
======================================
  Files          45      45           
  Lines        2756    2756           
  Branches      312     312           
======================================
  Hits         1006    1006           
  Misses       1750    1750           
Flag Coverage Δ
apple 14% <ø> (ø)
ios 15% <ø> (ø)
macos 14% <ø> (ø)
unittests 36% <ø> (ø)
www 45% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@fortuna
Copy link
Collaborator Author

fortuna commented Jul 17, 2023

Any thoughts?

Copy link
Contributor

@daniellacosse daniellacosse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There were a couple typos I caught, the rest are just suggestions/ideas.

src/cordova/apple/README.md Outdated Show resolved Hide resolved
src/cordova/apple/README.md Outdated Show resolved Hide resolved
src/cordova/apple/README.md Outdated Show resolved Hide resolved
```

To open the macOS project on XCode:
In the Console app, select the *Action > Include Info Messages* manu, and set the filter to "Library Path" "contains" "Outline.app":
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: menu

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also perhaps worth emphasizing that this is the MacOS Console application, not the console of the current terminal you're in

src/cordova/apple/README.md Outdated Show resolved Hide resolved
src/cordova/apple/README.md Show resolved Hide resolved
src/cordova/apple/README.md Show resolved Hide resolved
src/cordova/apple/README.md Outdated Show resolved Hide resolved
src/cordova/apple/README.md Show resolved Hide resolved
src/cordova/apple/README.md Show resolved Hide resolved
@fortuna fortuna merged commit 317e8f6 into master Jul 19, 2023
11 checks passed
@fortuna fortuna deleted the fortuna-readme branch July 19, 2023 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants