refactor(cordova/apple): simplify OutlineAppleLib #1660
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm getting rid of
OutlineConnectivity
. Note that the Go code already resolves host names (I added tests to demonstrate), so the resolution we were doing was unnecessary.I stopped passing the terrible
OutlineTunnel
to some VPN functions, passing atunnelId
andconfigJson
instead. I may rename it transportConfig or something else that reflects it's about the transport only.I identified a place where we are inspecting the transport config that we should eventually remove.
We need to introduce a new "tunnel config" concept that contains the tunnel id, the transport config and other parameters, but that will be later.
This is part of the effort of making the platform-code agnostic to the config.
/cc @bi-kh FYI