Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(cordova/apple): move network settings logic to Swift #1658

Merged
merged 18 commits into from
Jul 7, 2023

Remove deps

37f3d17
Select commit
Loading
Failed to load commit list.
Merged

refactor(cordova/apple): move network settings logic to Swift #1658

Remove deps
37f3d17
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Jul 7, 2023 in 0s

35% (-1%) compared to 97dae88

Details

Codecov Report

Patch coverage: 66% and project coverage change: -1 ⚠️

Comparison is base (97dae88) 35% compared to head (37f3d17) 35%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #1658    +/-   ##
=======================================
- Coverage      35%     35%    -1%     
=======================================
  Files          45      47     +2     
  Lines        2532    2852   +320     
  Branches      314     314            
=======================================
+ Hits          904    1012   +108     
- Misses       1628    1840   +212     
Impacted Files Coverage Δ
...ces/OutlineTunnelSources/OutlineConnectivity.swift 0% <ø> (ø)
...eLib/Sources/OutlineTunnelSources/OutlineVpn.swift 0% <0%> (ø)
...AppleLib/Sources/OutlineTunnelSources/Subnet.swift 84% <ø> (+84%) ⬆️
...PacketTunnelProviderSources/PacketTunnelProvider.m 0% <0%> (ø)
...b/Sources/OutlineTunnelSources/OutlineTunnel.swift 67% <66%> (+67%) ⬆️
...ib/Tests/OutlineTunnelTest/OutlineTunnelTest.swift 100% <100%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.