try to speed up npm?

Jigsaw-Code · Feb 7, 2024 · f56cfe8 · f56cfe8
1 parent db25255
commit f56cfe8
Show file tree

Hide file tree

Showing 2 changed files with 54 additions and 41 deletions.
diff --git a/.github/workflows/build_and_test_debug_client.yml b/.github/workflows/build_and_test_debug_client.yml
@@ -26,8 +26,9 @@ jobs:
       - name: Install Node
         uses: actions/setup-node@v3
         with:
-          node-version: 18
+          node-version-file: .nvmrc
           cache: npm
+          cache-dependency-path: ./package-lock.json
 
       - name: Install NPM Dependencies
         run: npm ci
@@ -60,9 +61,10 @@ jobs:
         with:
           node-version: 18
           cache: npm
+          cache-dependency-path: ./package-lock.json
 
       - name: Install NPM Dependencies
-        run: npm ci
+        run: npm ci --prod --ignore-scripts
 
       - name: Install Go
         uses: actions/setup-go@v4
@@ -87,11 +89,12 @@ jobs:
       - name: Install Node
         uses: actions/setup-node@v3
         with:
-          node-version: 18
+          node-version-file: .nvmrc
           cache: npm
+          cache-dependency-path: ./package-lock.json
 
       - name: Install NPM Dependencies
-        run: npm ci
+        run: npm ci --prod --ignore-scripts
 
       - name: Install Go
         uses: actions/setup-go@v4
@@ -116,11 +119,12 @@ jobs:
       - name: Install Node
         uses: actions/setup-node@v3
         with:
-          node-version: 18
+          node-version-file: .nvmrc
           cache: npm
+          cache-dependency-path: ./package-lock.json
 
       - name: Install NPM Dependencies
-        run: npm ci
+        run: npm ci --prod --ignore-scripts
 
       - name: Install Go
         uses: actions/setup-go@v4
@@ -157,11 +161,12 @@ jobs:
       - name: Install Node
         uses: actions/setup-node@v3
         with:
-          node-version: 18
+          node-version-file: .nvmrc
           cache: npm
+          cache-dependency-path: ./package-lock.json
 
       - name: Install NPM Dependencies
-        run: npm ci
+        run: npm ci --prod --ignore-scripts
 
       - name: Install Go
         uses: actions/setup-go@v4
@@ -198,11 +203,12 @@ jobs:
       - name: Install Node
         uses: actions/setup-node@v3
         with:
-          node-version: 18
+          node-version-file: .nvmrc
           cache: npm
+          cache-dependency-path: ./package-lock.json
 
       - name: Install NPM Dependencies
-        run: npm ci
+        run: npm ci --prod --ignore-scripts
 
       - name: Install Go
         uses: actions/setup-go@v4
@@ -236,11 +242,12 @@ jobs:
       - name: Install Node
         uses: actions/setup-node@v3
         with:
-          node-version: 18
+          node-version: nvmrc
           cache: npm
+          cache-dependency-path: ./package-lock.json
 
       - name: Install NPM Dependencies
-        run: npm ci
+        run: npm ci --prod --ignore-scripts
 
       - name: Install Go
         uses: actions/setup-go@v4

diff --git a/.github/workflows/build_and_test_debug_manager.yml b/.github/workflows/build_and_test_debug_manager.yml
@@ -24,11 +24,12 @@ jobs:
       - name: Install Node
         uses: actions/setup-node@v3
         with:
-          node-version: 18
+          node-version-file: .nvmrc
           cache: npm
+          cache-dependency-path: ./server_manager/package.json
 
       - name: Install NPM Dependencies
-        run: npm ci
+        run: npm ci --workspace=server_manager
 
       - name: Lint
         run: npm run lint
@@ -44,11 +45,12 @@ jobs:
       - name: Install Node
         uses: actions/setup-node@v3
         with:
-          node-version: 18
+          node-version-file: .nvmrc
           cache: npm
+          cache-dependency-path: ./server_manager/package.json
 
       - name: Install NPM Dependencies
-        run: npm ci
+        run: npm ci --workspace=server_manager
 
       - name: Manager Web Test
         run: npm run action server_manager/test
@@ -66,36 +68,39 @@ jobs:
       - name: Install Node
         uses: actions/setup-node@v3
         with:
-          node-version: 18
+          node-version: .nvmrc
           cache: npm
+          cache-dependency-path: ./server_manager/package.json
 
       - name: Install NPM Dependencies
-        run: npm ci
+        run: npm ci --workspace=server_manager --prod --ignore-scripts
 
       - name: Build Linux Manager
         run: npm run action server_manager/electron_app/build linux
 
-  windows_debug_build:
-    name: Windows Debug Build
-    runs-on: windows-2019
-    needs: web_test
-    env:
-      SENTRY_DSN: debug
-    steps:
-      - name: Checkout
-        uses: actions/[email protected]
-
-      - name: Install Node
-        uses: actions/setup-node@v3
-        with:
-          node-version: 18
-          cache: npm
-
-      - name: Install NPM Dependencies
-        run: npm ci
-
-      - name: Build Windows Manager
-        run: npm run action server_manager/electron_app/build windows
+  # TODO(daniellacosse): port bash scripts to windows so we can build the manager on windows
+  # windows_debug_build:
+  #   name: Windows Debug Build
+  #   runs-on: windows-2019
+  #   needs: web_test
+  #   env:
+  #     SENTRY_DSN: debug
+  #   steps:
+  #     - name: Checkout
+  #       uses: actions/[email protected]
+
+  #     - name: Install Node
+  #       uses: actions/setup-node@v3
+  #       with:
+  #         node-version-file: .nvmrc
+  #         cache: npm
+  #         cache-dependency-path: ./server_manager/package.json
+
+  #     - name: Install NPM Dependencies
+  #       run: npm ci --workspace=server_manager --prod --ignore-scripts
+
+  #     - name: Build Windows Manager
+  #       run: npm run action server_manager/electron_app/build windows
 
   mac_debug_build:
     name: MacOS Debug Build
@@ -110,11 +115,12 @@ jobs:
       - name: Install Node
         uses: actions/setup-node@v3
         with:
-          node-version: 18
+          node-version: .nvmrc
           cache: npm
+          cache-dependency-path: ./server_manager/package.json
 
       - name: Install NPM Dependencies
-        run: npm ci
+        run: npm ci --workspace=server_manager --prod --ignore-scripts
 
       - name: Set XCode Version
         run: sudo xcode-select -switch /Applications/Xcode_13.2.app