Skip to content

Commit

Permalink
fix(client/cordova/apple/ios): fix failing release build for the cord…
Browse files Browse the repository at this point in the history
…ova ios target (#1840)

* fix(cordova/apple/ios): fix failing build for the cordova ios target

* update entitilements

* update makefile
  • Loading branch information
daniellacosse authored Feb 27, 2024
1 parent 3bf9d6d commit f3e10d6
Show file tree
Hide file tree
Showing 5 changed files with 5 additions and 11 deletions.
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ $(BUILDDIR)/android/tun2socks.aar: $(GOMOBILE)

$(BUILDDIR)/ios/Tun2socks.xcframework: $(GOMOBILE)
# -iosversion should match what outline-client supports.
$(GOBIND) -iosversion=11.0 -target=ios,iossimulator -o $@ -ldflags '-w' -bundleid org.outline.tun2socks $(IMPORT_PATH)/$(ROOT_PKG)/outline/tun2socks $(IMPORT_PATH)/$(ROOT_PKG)/outline/shadowsocks
$(GOBIND) -iosversion=12.0 -target=ios,iossimulator -o $@ -ldflags '-w' -bundleid org.outline.tun2socks $(IMPORT_PATH)/$(ROOT_PKG)/outline/tun2socks $(IMPORT_PATH)/$(ROOT_PKG)/outline/shadowsocks

$(BUILDDIR)/macos/Tun2socks.xcframework: $(GOMOBILE)
# MACOSX_DEPLOYMENT_TARGET and -iosversion should match what outline-client supports.
Expand Down
8 changes: 4 additions & 4 deletions src/cordova/apple/xcode/ios/Outline.xcodeproj/project.pbxproj
Original file line number Diff line number Diff line change
Expand Up @@ -940,7 +940,7 @@
GCC_THUMB_SUPPORT = NO;
GCC_VERSION = "";
INFOPLIST_FILE = "Outline/Outline-Info.plist";
IPHONEOS_DEPLOYMENT_TARGET = 11.0;
IPHONEOS_DEPLOYMENT_TARGET = 12.0;
LD_RUNPATH_SEARCH_PATHS = "@executable_path/Frameworks";
ONLY_ACTIVE_ARCH = YES;
PRODUCT_BUNDLE_IDENTIFIER = org.outline.ios.client;
Expand Down Expand Up @@ -987,7 +987,7 @@
GCC_THUMB_SUPPORT = NO;
GCC_VERSION = "";
INFOPLIST_FILE = "Outline/Outline-Info.plist";
IPHONEOS_DEPLOYMENT_TARGET = 11.0;
IPHONEOS_DEPLOYMENT_TARGET = 12.0;
LD_RUNPATH_SEARCH_PATHS = "@executable_path/Frameworks";
ONLY_ACTIVE_ARCH = YES;
PRODUCT_BUNDLE_IDENTIFIER = org.outline.ios.client;
Expand Down Expand Up @@ -1391,7 +1391,7 @@
GCC_WARN_UNINITIALIZED_AUTOS = YES;
GCC_WARN_UNUSED_FUNCTION = YES;
GCC_WARN_UNUSED_VARIABLE = YES;
IPHONEOS_DEPLOYMENT_TARGET = 11.0;
IPHONEOS_DEPLOYMENT_TARGET = 12.0;
MACOSX_DEPLOYMENT_TARGET = "$(RECOMMENDED_MACOSX_DEPLOYMENT_TARGET)";
ONLY_ACTIVE_ARCH = YES;
SDKROOT = iphoneos;
Expand Down Expand Up @@ -1435,7 +1435,7 @@
GCC_WARN_UNINITIALIZED_AUTOS = YES;
GCC_WARN_UNUSED_FUNCTION = YES;
GCC_WARN_UNUSED_VARIABLE = YES;
IPHONEOS_DEPLOYMENT_TARGET = 11.0;
IPHONEOS_DEPLOYMENT_TARGET = 12.0;
MACOSX_DEPLOYMENT_TARGET = "$(RECOMMENDED_MACOSX_DEPLOYMENT_TARGET)";
SDKROOT = iphoneos;
SKIP_INSTALL = NO;
Expand Down
1 change: 0 additions & 1 deletion src/cordova/apple/xcode/ios/Outline/Outline.entitlements
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@
<key>com.apple.security.application-groups</key>
<array>
<string>group.org.outline.ios.client</string>
<string>$(TeamIdentifierPrefix)org.outline.macos.client</string>
</array>
<key>com.apple.security.network.client</key>
<true/>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@
<key>com.apple.security.application-groups</key>
<array>
<string>group.org.outline.ios.client</string>
<string>$(TeamIdentifierPrefix)org.outline.macos.client</string>
</array>
<key>com.apple.security.network.client</key>
<true/>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,6 @@
</array>
<key>com.apple.security.app-sandbox</key>
<true/>
<key>com.apple.security.application-groups</key>
<array>
<string>$(TeamIdentifierPrefix)org.outline.macos.client</string>
</array>
<key>com.apple.security.files.user-selected.read-only</key>
<true/>
</dict>
Expand Down

0 comments on commit f3e10d6

Please sign in to comment.