Skip to content

Commit

Permalink
Move lint check to its own workflow.
Browse files Browse the repository at this point in the history
  • Loading branch information
sbruens committed Apr 15, 2024
1 parent e334630 commit 127ef5f
Show file tree
Hide file tree
Showing 3 changed files with 40 additions and 29 deletions.
7 changes: 2 additions & 5 deletions .github/workflows/build_and_test_debug_client.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,6 @@ jobs:
- name: Install NPM Dependencies
run: npm set cache .npm && npm ci

- name: Run Linter
run: npm run action lint

- name: Build Web App
run: npm run action client/src/www/build

Expand Down Expand Up @@ -133,7 +130,7 @@ jobs:

- name: Build Tun2Socks (required for Test OutlineAppleLib)
run: npm run action client/src/tun2socks/build macos

- name: Test OutlineAppleLib
run: npm run action client/src/cordova/test macos

Expand Down Expand Up @@ -174,7 +171,7 @@ jobs:
go-version-file: '${{ github.workspace }}/go.mod'

- name: Build Tun2Socks (required for Test OutlineAppleLib)
run: npm run action client/src/tun2socks/build ios
run: npm run action client/src/tun2socks/build ios

- name: Test OutlineAppleLib
run: npm run action client/src/cordova/test ios
Expand Down
27 changes: 3 additions & 24 deletions .github/workflows/build_and_test_debug_manager.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,30 +14,9 @@ on:
- master

jobs:
lint:
name: Lint
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/[email protected]

- name: Install Node
uses: actions/setup-node@v3
with:
node-version-file: .nvmrc
cache: npm
cache-dependency-path: ./server_manager/package.json

- name: Install NPM Dependencies
run: npm ci

- name: Lint
run: npm run lint

web_test:
name: Web Test
runs-on: ubuntu-latest
needs: lint
steps:
- name: Checkout
uses: actions/[email protected]
Expand All @@ -54,7 +33,7 @@ jobs:

- name: Manager Web Test
run: npm run action server_manager/test

linux_debug_build:
name: Linux Debug Build
runs-on: ubuntu-latest
Expand Down Expand Up @@ -101,7 +80,7 @@ jobs:

- name: Build Windows Manager
run: npm run action server_manager/electron_app/build windows

mac_debug_build:
name: MacOS Debug Build
runs-on: macos-11
Expand All @@ -121,7 +100,7 @@ jobs:

- name: Install NPM Dependencies
run: npm ci

- name: Set XCode Version
run: sudo xcode-select -switch /Applications/Xcode_13.2.app

Expand Down
35 changes: 35 additions & 0 deletions .github/workflows/lint.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@
name: Lint

concurrency:
group: ${{ github.head_ref || github.ref }}
cancel-in-progress: true

on:
pull_request:
types:
- opened
- synchronize
push:
branches:
- master

jobs:
lint:
name: Lint
runs-on: ubuntu-latest
steps:
- name: Checkout
uses: actions/[email protected]

- name: Install Node
uses: actions/setup-node@v3
with:
node-version-file: .nvmrc
cache: npm
cache-dependency-path: ./server_manager/package.json

- name: Install NPM Dependencies
run: npm ci

- name: Lint
run: npm run lint

0 comments on commit 127ef5f

Please sign in to comment.