Change when we do source file verification #344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…source verificiation before looking at the working directory. Now we convert all source files to an absolute file path if needed, then perform globbing and then do source verification. This fixes a bug where we would not find source files if the working directory was not the same as the source file directory.
|
@Lrakotoson what you think of this solution? :) Everyone else, feel free to come with suggestion or review |
JessicaTegner
added a commit
that referenced
this pull request
Oct 25, 2023
This reverts commit 31fd7d5.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change when we do source file verification #342. Previously we did sourceverificiation before looking at the working directory. Now we convert all source files to an absolute file path if needed, then perform globbing and then do source verification. This fixes a bug where we would not find source files if the working directory was not the same as the source file directory.