Created an Assertion for StatusCodeShouldBeSuccess #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hawxy
force-pushed
the
add-extension-for-success-status-code
branch
from
27b90d6
to
5b0d011
Compare
|
Thanks for the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unsolicited contribution - but I often want to be a little fuzzy on asserting status codes (a 200 is as good as a 201, or a 204, for example). I added an assertion for
api.StatusCodeShouldBeSuccess()that will pass if the status code is in the proper range of "success".Since Alba's default behavior is to fail if there is no assertion on the status code and it returns anything but a 200, this seems like a good accommodation. (I'd prefer the default was this, but I get why others wouldn't, and don't want a breaking change anyhow).
I've had this as my own custom assertion for a while, and don't mind keeping it that way, but if it is helpful, take it.