#16 show data in frontend #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
added 9 commits
January 23, 2024 17:09
Flofie
reviewed
Jan 24, 2024
Flofie
reviewed
Jan 24, 2024
Flofie
reviewed
Jan 24, 2024
Flofie
reviewed
Jan 24, 2024
Flofie
reviewed
Jan 24, 2024
| @@ -103,11 +110,10 @@ describe("DataAnalyzer", () => { | |||
| { __rowId: 2, age: 25 }, | |||
| { __rowId: 3, name: "" }, | |||
| { __rowId: 4, name: null }, | |||
| { __rowId: 5, name: undefined }, | |||
There was a problem hiding this comment.
was ist an dem testcase verkehrt?
There was a problem hiding this comment.
Undefined ist aktuell nicht in den erlaubten Types. Eigentlich müsste man null auch entfernen, da leere Zellen mit "" aufgefüllt werden
Flofie
reviewed
Jan 24, 2024
Flofie
reviewed
Jan 24, 2024
| import { ValidationError } from "../ValidationError"; | ||
|
|
||
| export class EnumValidator implements Validator { | ||
| public validate( |
There was a problem hiding this comment.
bei enum validation hast du wahrscheinlich oft die selben werte, da könnte man durch caching evtl. noch ein paar ms rauskitzeln
There was a problem hiding this comment.
Die einzige Optimierung, die mir jetzt auf die schnelle einfällt, wäre das speichern der Values als Set statt Array (aber das müsste man immer convertieren, weil es wahrscheinlich nicht serializable ist). Oder hast du eine andere Idee?
Flofie
reviewed
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.