chore(app): move map out of for loop

Jank1310 · Jan 24, 2024 · a0fe932 · a0fe932
1 parent 488e9fb
commit a0fe932
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 4 deletions.
diff --git a/app/temporal/src/domain/validators/EmailValidator.ts b/app/temporal/src/domain/validators/EmailValidator.ts
@@ -9,7 +9,8 @@ export class EmailValidator {
     columnConfig: { column: string; regex?: string }[]
   ): Record<string, ValidationError> {
     const errors: Record<string, ValidationError> = {};
-    for (const columnToValidate of columnConfig.map((item) => item.column)) {
+    const columnsToValidate = columnConfig.map((item) => item.column);
+    for (const columnToValidate of columnsToValidate) {
       let dataToValidate = row[columnToValidate];
       if (EMAIL_REGEX.test((dataToValidate as string) ?? "") === false) {
         errors[columnToValidate] = {

diff --git a/app/temporal/src/domain/validators/PhoneValidator.ts b/app/temporal/src/domain/validators/PhoneValidator.ts
@@ -7,7 +7,8 @@ export class PhoneValidator {
     columnConfig: { column: string; regex?: string }[]
   ): Record<string, ValidationError> {
     const errors: Record<string, ValidationError> = {};
-    for (const columnToValidate of columnConfig.map((item) => item.column)) {
+    const columnsToValidate = columnConfig.map((item) => item.column);
+    for (const columnToValidate of columnsToValidate) {
       let dataToValidate = row[columnToValidate];
       // check if defaultCountry DE is ok
       if (

diff --git a/app/temporal/src/domain/validators/RequiredValidator.ts b/app/temporal/src/domain/validators/RequiredValidator.ts
@@ -6,7 +6,8 @@ export class RequiredValidator {
     columnConfig: { column: string; regex?: string }[]
   ): Record<string, ValidationError> {
     const errors: Record<string, ValidationError> = {};
-    for (const columnToValidate of columnConfig.map((item) => item.column)) {
+    const columnsToValidate = columnConfig.map((item) => item.column);
+    for (const columnToValidate of columnsToValidate) {
       let dataToValidate = row[columnToValidate];
       if (dataToValidate == null || dataToValidate === "") {
         errors[columnToValidate] = {

diff --git a/app/temporal/src/domain/validators/UniqueValidator.ts b/app/temporal/src/domain/validators/UniqueValidator.ts
@@ -10,7 +10,8 @@ export class UniqueValidator {
     stats: Stats = {}
   ) {
     const errors: Record<string, ValidationError> = {};
-    for (const columnToValidate of columnConfig.map((item) => item.column)) {
+    const columnsToValidate = columnConfig.map((item) => item.column);
+    for (const columnToValidate of columnsToValidate) {
       let dataToValidate = row[columnToValidate];
       if (
         stats[columnToValidate] &&