[WIP] Modularize JabRef with JPMS #4230
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 78c98bc)
* Fix fetcher tests remove uncessary logging in l10n which makes fetcher test fail ISBN tests still fail both Fix arxiv tests, eprint now has url in front * rework fetcher tests Fix logging configuration Fix eprint field of arxiv Return empty results when 404 or 400 encountered Add logging in that case * fix checkstyle * match both https and http prefixes in arxiv * inline prefs in setup method * fix ebook.de test record, as there is a new version of that book entry * move comment
|
@florian-beetz I just fixed some issue with the test xml config part of my fetcher fixes (it was named wrong): |
|
Just tested it with this merged, but I have the same issue. Here is a full log. |
RichTextFX will no longer be maintained FXMisc/RichTextFX#768
* update mockito * update archunit and errorprone * fix typo
* Replace old fetcher stuff in command line interface * Remove cli output * Make help file optional * Rework web search pane in javafx * Show web search and group panes by default * Use better binding and init default fetcher in view model as it should be * remove obsolete l10n keys set search button to default so search can be executed by hitting enter * fix wrong string util class
Adapt the url of returned data
* Make attached files relative to the file directory Fixes JabRef#4201 Open files with default OS application if no External file type is present * add changelog * use method from linked files view model for linked file * fix opening of file from menu add monadic binding * fix variable name
* Fix importer vulnerability Fixed issue JabRef#4229 where importer was vulnerable to XXE attacks by disabling DTDs along with adding warning to logger if features are unavailable. fixes JabRef#4229 * Fix minor code errors and logger optimization Removed author line in class comment. Reworded CHANGLOG.md. Set DTD features to individual final static constants. Optimized logger by parameterizing feature and error. * Rearrange import statments for project compatibility * Remove merge artefacts from changelog
# Conflicts: # build.gradle
(cherry picked from commit 8dce805)
|
I just tried also extracting a logic module, but I encountered a problem: Do you have any ideas how this could be refactored to be able to extract the logic module? |
|
Not every class in |
|
@tobiasdiez Nice, that worked great 👍 |
|
@florian-beetz @tobiasdiez - Since @lenhard pinged us because of architecture. May I ask about the state of this PR? I would not like to put work into the trash. I would really like to keep this going. |
|
@koppor This PR is still pretty rough around the edges, and I could not work on this recently. I also don't know if it makes much sense to continue working on this before #3421 is finished. |
In the devcall, we agreed with this sentiment. The important thing right now is to have a workable Java 9 build, and then worry about the moduliarization of JabRef itself. Thus, I'll put this PR into sleep mode for now. Thanks nonetheless for your work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This splits JabRef into multiple JPMS modules. (see #3704)
JabRef runs with these changes, but there are some issues:
ClassCastException: org.slf4j/org.slf4j.helpers.NOPLoggerFactory cannot be cast to org.gradle.internal.logging.slf4j.OutputEventListenerBackedLoggerContext)