[WIP] JDK9 Migration #3888
Closed
[WIP] JDK9 Migration #3888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # build.gradle
- brute force attempt at making JabRef runnable with Java 9 - simply removed all the things Java 9 complains about (without fix yet) Split Packages: - LibreOffice - ArchUnit Invalid Module Name: - Latex2Unicode Internal APIs: - only JFX
6 tasks
Siedlerchr
reviewed
Mar 24, 2018
| InputMethodSupport.inputMethodEventComposed(t, e.getCommittedCharacterCount()), | ||
| t.substring(0, e.getCommittedCharacterCount()), | ||
| insertionIndex); | ||
| // TODO: temporarily removed as this is internal API |
There was a problem hiding this comment.
Fortunately with the migration to javafx in the maintable-beta branch #3621 this class is no longer needed. So you can leave it like that
Siedlerchr
reviewed
Mar 24, 2018
| @@ -168,7 +185,8 @@ dependencies { | |||
| testCompile 'org.reflections:reflections:0.9.11' | |||
| testCompile 'org.xmlunit:xmlunit-core:2.5.1' | |||
| testCompile 'org.xmlunit:xmlunit-matchers:2.5.1' | |||
| testCompile 'com.tngtech.archunit:archunit-junit:0.5.0' | |||
| // TODO: has a split package between archunit and archunit-junit | |||
| // testCompile 'com.tngtech.archunit:archunit-junit:0.5.0' | |||
There was a problem hiding this comment.
I just saw that they already made their lib compataible with java9 (requires snapshot version=
TNG/ArchUnit#47
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes #3421
This compiles and runs with Oracle JDK9.