Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Setting to hide balances from the "Accounts" tab #3478

Merged
merged 3 commits into from
Sep 6, 2024
Merged

[FEATURE] Setting to hide balances from the "Accounts" tab #3478

merged 3 commits into from
Sep 6, 2024

Conversation

paulolima18
Copy link
Contributor

Pull request (PR) checklist

Please check if your pull request fulfills the following requirements:

  • [ x] I've read the Contribution Guidelines and my PR doesn't break the rules.
  • [ x] I've read and understand the Developer Guidelines.
  • [ x] I confirm that I've run the code locally and everything works as expected.
  • [ x] My PR includes only the necessary changes to fix the issue (i.e., no unnecessary files or lines of code are changed).
  • [ x] 🎬 I've attached a screen recording of using the new code to the next paragraph (if applicable).

Screen recording of your changes (if applicable):

recording.webm

What's changed?

Describe with a few bullets what's new:

  • I've added the setting to hide balances from the "Accounts" tab
Before After
first second

Risk factors

What may go wrong if we merge your PR?

  • Users may want more functionality or not like the feature.

In what cases won't your code work?

  • ...
  • ...

Does this PR close any GitHub issues? (do not delete)

Troubleshooting GitHub Actions (CI) failures ❌

Pull request checks failing? Read our CI Troubleshooting guide.

@paulolima18
Add Setting to hide balances from the "Accounts" tab
db81b5d
@paulolima18
Merge remote-tracking branch 'origin/fix-issue-3475' into fix-issue-3475
9fff866 
# Conflicts:
#	screen/accounts/src/main/java/com/ivy/accounts/AccountsTab.kt
#	shared/domain/src/main/java/com/ivy/domain/features/IvyFeatures.kt
@ILIYANGERMANOV ILIYANGERMANOV merged commit 7eaaba2 into Ivy-Apps:main Sep 6, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ILIYANGERMANOV ILIYANGERMANOV ILIYANGERMANOV approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE] Setting to hide balances from the "Accounts" tab
2 participants
@paulolima18 @ILIYANGERMANOV