Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Incorrect Time Display After Saving Transaction #3433

Closed
wants to merge 1 commit into from
Closed

Fix Incorrect Time Display After Saving Transaction #3433

wants to merge 1 commit into from

Conversation

shamim-emon
Copy link
Member

@shamim-emon shamim-emon commented Aug 27, 2024 •
edited
Loading

Pull request (PR) checklist

Please check if your pull request fulfills the following requirements:

  • I've read the Contribution Guidelines and my PR doesn't break the rules.
  • I've read and understand the Developer Guidelines.
  • I confirm that I've run the code locally and everything works as expected.
  • My PR includes only the necessary changes to fix the issue (i.e., no unnecessary files or lines of code are changed).
  • 🎬 I've attached a screen recording of using the new code to the next paragraph (if applicable).

Screen recording of your changes (if applicable):

What's changed?

Describe with a few bullets what's new:

  • I've fixed Incorrect Time Display After Saving Transaction issue

Risk factors

What may go wrong if we merge your PR?

  • No known case

In what cases won't your code work?

  • No known case

Does this PR close any GitHub issues? (do not delete)

Troubleshooting GitHub Actions (CI) failures ❌

Pull request checks failing? Read our CI Troubleshooting guide.

@shamim-emon shamim-emon changed the title [BUG] Incorrect Time Display After Saving Transaction Fix Incorrect Time Display After Saving Transaction Aug 27, 2024
akashs056
akashs056 reviewed Aug 27, 2024
View reviewed changes
screen/edit-transaction/src/main/java/com/ivy/transaction/EditTransactionViewModel.kt
@@ -704,7 +705,7 @@ class EditTransactionViewModel @Inject constructor(
dateTime = when {
loadedTransaction().dateTime == null &&
dueDate.value == null -> {
timeNowUTC()
timeProvider.utcNow().atZone(timeProvider.getZoneId()).toLocalDateTime()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested it, the date is showing correctly after saving the transaction but the is issue in the balance calculation. the balance didnt get updated for me...

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @akashs056! Much appreciated that you tested 🙌

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@akashs056 thanks for pointing it out.

ILIYANGERMANOV
ILIYANGERMANOV requested changes Aug 27, 2024
View reviewed changes
Copy link
Collaborator

@ILIYANGERMANOV ILIYANGERMANOV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Folks, let's do the proper fix by reworking the entire app time handling using the TimeConverter API - small fixes won't solve it - they fix one thing and break another

@shamim-emon
Copy link
Member Author

Folks, let's do the proper fix by reworking the entire app time handling using the TimeConverter API - small fixes won't solve it - they fix one thing and break another

@ILIYANGERMANOV sure, since this will be a big task, can I create another issue and attach with this PR once goal is reached?

@ILIYANGERMANOV
Copy link
Collaborator

Folks, let's do the proper fix by reworking the entire app time handling using the TimeConverter API - small fixes won't solve it - they fix one thing and break another

@ILIYANGERMANOV sure, since this will be a big task, can I create another issue and attach with this PR once goal is reached?

Yeah that makes sense

@ILIYANGERMANOV ILIYANGERMANOV added the requested changes Changes are needed. Please, apply them label Aug 28, 2024
@shamim-emon shamim-emon closed this by deleting the head repository Aug 29, 2024
@shamim-emon
Copy link
Member Author

@ILIYANGERMANOV @akashs056 will reopen PR once done with TimeConverter API migration is done successfully.

@ILIYANGERMANOV
Copy link
Collaborator

@ILIYANGERMANOV @akashs056 will reopen PR once done with TimeConverter API migration is done successfully.

@shamim-emon I have errors in #3435 (the app crashes with Long overflow) and other stuff are broken. I'll see I'll easily fix them. Ideally, at one point we should rewrite the legacy properly and cover it with tests (like the new APIs)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akashs056 akashs056 akashs056 left review comments

@ILIYANGERMANOV ILIYANGERMANOV ILIYANGERMANOV requested changes

Assignees
No one assigned
Labels
requested changes Changes are needed. Please, apply them
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Incorrect Time Display After Saving Transaction
3 participants
@shamim-emon @ILIYANGERMANOV @akashs056