Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: removed csvFormat() and kept UTC format #3426

Merged
merged 6 commits into from
Aug 28, 2024

Conversation

akashs056
Copy link
Contributor

@akashs056 akashs056 commented Aug 24, 2024

Pull request (PR) checklist

Please check if your pull request fulfills the following requirements:

  • I've read the Contribution Guidelines and my PR doesn't break the rules.
  • I've read and understand the Developer Guidelines.
  • I confirm that I've run the code locally and everything works as expected.
  • My PR includes only the necessary changes to fix the issue (i.e., no unnecessary files or lines of code are changed).
  • 🎬 I've attached a screen recording of using the new code to the next paragraph (if applicable).

Screen recording of your changes (if applicable):

WhatsApp Image 2024-08-24 at 13 21 55_f9f86d96

What's changed?

I have updated the code to remove the csvFormat() function and instead kept the UTC format with the "Z" for both date and dueDate. After testing, it works perfectly fine and correctly handles the UTC time. The export and import processes function smoothly without any issues.

Does this PR close any GitHub issues? (do not delete)

@akashs056
Copy link
Contributor Author

I didn't use the latest time converter you implemented, but this solution also works fine for the current issue

@ILIYANGERMANOV ILIYANGERMANOV added the requested changes Changes are needed. Please, apply them label Aug 28, 2024
@ILIYANGERMANOV ILIYANGERMANOV merged commit 6c3937d into Ivy-Apps:main Aug 28, 2024
9 checks passed
@akashs056 akashs056 deleted the fix-issue-3422 branch August 28, 2024 16:11
@akashs056 akashs056 mentioned this pull request Aug 30, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
requested changes Changes are needed. Please, apply them
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Incorrect time shown in exported csv file
2 participants