Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed convertLocalToUtc from setupTimePicker in rootactivity.kt #3399

Closed
wants to merge 1 commit into from

Conversation

viratde
Copy link

@viratde viratde commented Aug 6, 2024

Pull request (PR) checklist

Please check if your pull request fulfills the following requirements:

  • I've read the Contribution Guidelines and my PR doesn't break the rules.
  • I've read and understand the Developer Guidelines.
  • I confirm that I've run the code locally and everything works as expected.
  • My PR includes only the necessary changes to fix the issue (i.e., no unnecessary files or lines of code are changed).
  • 🎬 I've attached a screen recording of using the new code to the next paragraph (if applicable).

Screen recording of your changes (if applicable):

What's changed?

Describe with a few bullets what's new:

  • I've fixed the incorrect value returned by time picker

Before
image

After
image

Risk factors

What may go wrong if we merge your PR?

  • ...
  • ...

In what cases won't your code work?

  • If the time needed to be stored in the UTC format only, then the time picker will give incorrect values

Does this PR close any GitHub issues? (do not delete)

Troubleshooting GitHub Actions (CI) failures ❌

Pull request checks failing? Read our CI Troubleshooting guide.

Copy link
Collaborator

@ILIYANGERMANOV ILIYANGERMANOV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@viratde can you attach a screen recording that proves:
0. For the test set your device to India timezone

  1. When the user creates a transaction it's created at the correct time.
  2. The Income/Expense and Balance get correctly updated.
  3. Editing the time of the transaction works correctly

@viratde viratde closed this Aug 6, 2024
@viratde
Copy link
Author

viratde commented Aug 6, 2024

There is more work required on this bug

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants