Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create feature button at settings page #3389

Merged
merged 2 commits into from
Aug 4, 2024

Conversation

letsaguiar
Copy link
Contributor

Pull request (PR) checklist

Please check if your pull request fulfills the following requirements:

  • I've read the Contribution Guidelines and my PR doesn't break the rules.
  • I've read and understand the Developer Guidelines.
  • I confirm that I've run the code locally and everything works as expected.
  • My PR includes only the necessary changes to fix the issue (i.e., no unnecessary files or lines of code are changed).
  • 🎬 I've attached a screen recording of using the new code to the next paragraph (if applicable).

Screen recording of interacting with your changes:

Screen_recording_20240803_033418.webm

What's changed?

Describe with a few bullets what's new:

  • I've created a new button at the end of the App Settings section of the Settings screen. It redirects to the Features Screen.
Before After
{media} {media}
{media} {media}

Risk factors

What may go wrong if we merge your PR?

  • ...
  • ...

In what cases won't your code work?

  • ...
  • ...

Does this PR close any GitHub issues? (do not delete)

Troubleshooting GitHub Actions (CI) failures ❌

Pull request checks failing? Read our CI Troubleshooting guide.

Copy link
Collaborator

@ILIYANGERMANOV ILIYANGERMANOV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Fix the merge conflicts and we can merge

@ILIYANGERMANOV ILIYANGERMANOV merged commit d3e475a into Ivy-Apps:main Aug 4, 2024
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make the "Features" screen visible as a button in Settings
2 participants