-
Notifications
You must be signed in to change notification settings - Fork 628
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue 3138 #3337
Fix issue 3138 #3337
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, great UX and a cool solution! Thank you for the nice PR description 💯
Before merging it you need address the screen architecture and work only inside the settings module. If you face any issues, do tag me and comment and I'll help :)
screen/settings/src/main/java/com/ivy/settings/SettingsScreen.kt
Outdated
Show resolved
Hide resolved
@suyash01 check this doc Also feel free to suggest how to make it better |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making the changes!
Pull request (PR) checklist
Please check if your pull request fulfills the following requirements:
Screen recording of interacting with your changes:
language_option.mp4
What's changed?
Describe with a few bullets what's new:
Risk factors
What may go wrong if we merge your PR?
In what cases won't your code work?
Does this PR close any GitHub issues?
Troubleshooting CI failures ❌
Pull request checks failing? Read our CI Troubleshooting guide.