Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the library that causing 3328 #3330

Merged
merged 4 commits into from
Jul 11, 2024

Conversation

vk92257
Copy link
Contributor

@vk92257 vk92257 commented Jul 11, 2024

Commented out the (com.google.android.play:asset-delivery) library that was causing the issue and found we have not use the code of the given library into our project.

Closes #3328

Copy link
Collaborator

@ILIYANGERMANOV ILIYANGERMANOV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vk92257 codewise looks good but please use our PR template. You need to:

  • specify which issue this PR closes
  • add a screen recording that the app opens and works after the change

gradle/libs.versions.toml Outdated Show resolved Hide resolved
@ILIYANGERMANOV ILIYANGERMANOV added the requested changes Changes are needed. Please, apply them label Jul 11, 2024
@ILIYANGERMANOV ILIYANGERMANOV merged commit 66680f3 into Ivy-Apps:main Jul 11, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
requested changes Changes are needed. Please, apply them
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RELEASE BLOCKER] Remove Foreground service permissions
2 participants