Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #3133 #3269

Merged
merged 14 commits into from
Jul 6, 2024
Merged

Fix issue #3133 #3269

merged 14 commits into from
Jul 6, 2024

Conversation

biplab1
Copy link
Contributor

@biplab1 biplab1 commented Jul 6, 2024

Pull Request (PR) Checklist

Please check if your pull request fulfills the following requirements:

  • The PR is submitted to the main branch.
  • I've read the Contribution Guidelines and my PR doesn't break the rules.
  • I've read and understand the Developer Guidelines.
  • I confirm that I've run the code locally and everything works as expected.
  • 🎬 I've attached a screen recoding of the changes.

Tip: drag & drop the video to the PR description.

What's changed?

Describe with a few bullets what's new:

  • Fixed typos and mistakes in Dev guidelines and its pages, excluding Yoda-Style-Architecture.md

💡 Tip: Please, attach screenshots and screen recordings. It helps a lot!

Risk Factors

What may go wrong if we merge your PR?

  • a
  • b

In what cases your code won't work?

  • a
  • b

Does this PR closes any GitHub Issues?

Check Ivy Wallet Issues.

Replace ISSUE_NUMBER with the number of the GitHub issue that this PR is fixing. If you've done that correctly, you'll see the issue title linked when previewing your PR description.

!Note: Do not link the PR number. Link the number/id of the GitHub Issue from issues.

Troubleshooting CI failures ❌

GitHub Actions failing? Read our CI Troubleshooting guide.

Copy link
Collaborator

@ILIYANGERMANOV ILIYANGERMANOV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing work!! The docs looks much more readable and nicer after your contribution 👏
Please revert the .idea file changes and we can merge

.idea/.name Outdated Show resolved Hide resolved
.idea/checkstyle-idea.xml Outdated Show resolved Hide resolved
@ILIYANGERMANOV ILIYANGERMANOV added keep Keep it from automatically getting closed by Stale requested changes Changes are needed. Please, apply them labels Jul 6, 2024
@biplab1
Copy link
Contributor Author

biplab1 commented Jul 6, 2024

Thank you for the kind words! I'm glad to hear that the documentation improvements are appreciated.

I've reverted the .idea file changes as requested. The pull request should now be ready for merging.

Please let me know if there's anything else needed.

Copy link
Collaborator

@ILIYANGERMANOV ILIYANGERMANOV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work 👏

@biplab1
Copy link
Contributor Author

biplab1 commented Jul 6, 2024

Thank you! I'm glad you liked it.

@ILIYANGERMANOV ILIYANGERMANOV merged commit 1a0de49 into Ivy-Apps:main Jul 6, 2024
8 checks passed
@biplab1 biplab1 deleted the fix-issue-3133 branch July 9, 2024 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
keep Keep it from automatically getting closed by Stale requested changes Changes are needed. Please, apply them
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix typos in the Developer Guidelines
2 participants