-
Notifications
You must be signed in to change notification settings - Fork 629
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge branch 'main' into fix-issue-3315
- Loading branch information
Showing
155 changed files
with
2,448 additions
and
1,967 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,52 +1,39 @@ | ||
## Pull Request (PR) Checklist | ||
## Pull request (PR) checklist | ||
Please check if your pull request fulfills the following requirements: | ||
- [ ] The PR is submitted to the `main` branch. | ||
<!--💡 Tip: Tick checkboxes like this: [x] 💡--> | ||
- [ ] I've read the [Contribution Guidelines](https://github.com/Ivy-Apps/ivy-wallet/blob/main/CONTRIBUTING.md) and my PR doesn't break the rules. | ||
- [ ] I've read and understand the [Developer Guidelines](https://github.com/Ivy-Apps/ivy-wallet/blob/main/docs/Guidelines.md). | ||
- [ ] I confirm that I've run the code locally and everything works as expected. | ||
- [ ] 🎬 I've attached a **screen recoding** of the changes. | ||
- [ ] My PR includes only the necessary changes to fix the issue (i.e., no unnecessary files or lines of code are changed). | ||
|
||
> Tip: drag & drop the video to the PR description. | ||
- [ ] 🎬 I've attached a **screen recording** of using the new code to the next paragraph (if applicable). | ||
## Screen recording of interacting with your changes: | ||
<!--💡 Tip: Drag & drop the video here. 💡--> | ||
|
||
## What's changed? | ||
<!-- | ||
Tip: you can attach screenshots using a markdown table. | ||
Before | After | ||
--|-- | ||
image1 | image2 | ||
--> | ||
|
||
Describe with a few bullets **what's new:** | ||
- a | ||
- b | ||
- c | ||
|
||
> 💡 Tip: Please, attach screenshots and screen recordings. It helps a lot! | ||
## Risk Factors | ||
|
||
<!--💡 Tip: After each more important point leave one line empty and show your changes in markdown table with screenshots or screen recordings replacing {media}. In the end, it should look like this: 💡--> | ||
- I've fixed... | ||
|
||
Before|After | ||
---------|--------- | ||
{media}|{media} | ||
{media}|{media} | ||
- ... | ||
- ... | ||
## Risk factors | ||
**What may go wrong if we merge your PR?** | ||
|
||
- a | ||
- b | ||
|
||
**In what cases your code won't work?** | ||
|
||
- a | ||
- b | ||
|
||
## Does this PR closes any GitHub Issues? | ||
|
||
Check **[Ivy Wallet Issues](https://github.com/Ivy-Apps/ivy-wallet/issues)**. | ||
|
||
- Closes #ISSUE_NUMBER | ||
|
||
> Replace `ISSUE_NUMBER` with the number of the GitHub issue that this PR is fixing. If you've done that correctly, you'll see the issue title linked when previewing your PR description. | ||
> **!Note:** Do **not** link the PR number. Link the number/id of the GitHub Issue from [issues](https://github.com/Ivy-Apps/ivy-wallet/issues). | ||
- ... | ||
- ... | ||
|
||
**In what cases won't your code work?** | ||
- ... | ||
- ... | ||
## Does this PR close any GitHub issues? | ||
- Closes #{ISSUE_NUMBER} | ||
<!--❗For example: - Closes #123 ❗--> | ||
<!--💡 Tip: Replace {ISSUE_NUMBER} with the number of Ivy Wallet ISSUE (https://github.com/Ivy-Apps/ivy-wallet/issues)(❗NOT PR❗) which this pull request fixes. If done correctly, you'll see the issue title linked on PR preview. 💡--> | ||
<!--💡 Tip: Multiple issues: | ||
- Closes #{ISSUE_NUMBER_1}, closes #{ISSUE_NUMBER_2}, closes #{ISSUE_NUMBER_3} | ||
💡--> | ||
## Troubleshooting CI failures ❌ | ||
|
||
GitHub Actions failing? Read our [CI Troubleshooting guide](https://github.com/Ivy-Apps/ivy-wallet/blob/main/docs/CI-Troubleshooting.md). | ||
Pull request checks failing? Read our [CI Troubleshooting guide](https://github.com/Ivy-Apps/ivy-wallet/blob/main/docs/CI-Troubleshooting.md). |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1 @@ | ||
Ivy Wallet internal testing release, please refer to (https://github.com/Ivy-Apps/ivy-wallet/releases) for changelog. | ||
Ivy Wallet periodic release, refer to (https://github.com/Ivy-Apps/ivy-wallet/releases) for changelog. If you find any issues, please report them in our GitHub repository. |
Oops, something went wrong.