Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give errors in addReference and removeReference a callstack #410

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

jorisdral
Copy link
Collaborator

This makes it slightly easier to see where assertions related to reference count invariants fail.

Copy link
Collaborator

@dcoutts dcoutts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. The redundant constraint warning for the no-debug builds makes some sense, but I'd argue it's a GHC bug. Check if such a bug has been filed already and if not, file one.

@jorisdral jorisdral self-assigned this Oct 1, 2024
This makes it slightly easier to see where assertions related to reference count
invariants fail.
@jorisdral jorisdral added this pull request to the merge queue Oct 1, 2024
Merged via the queue into main with commit a308fb8 Oct 1, 2024
24 checks passed
@jorisdral jorisdral deleted the jdral/refcount-callstack branch October 1, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants