Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure epoch length equation is satisfied for testnet #5679

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

carbolymer
Copy link
Contributor

@carbolymer carbolymer commented Feb 19, 2024

Description

This PR makes sure that epoch length equation is satisfied for the testnet.

Additionally, 140s timeout is removed for InfoAction test.

This is an attempt towards fixing:

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • roundtrip tests
    • integration tests
      See Runnings tests for more details
  • Any changes are noted in the CHANGELOG.md for affected package
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • Self-reviewed the diff

Note on CI

If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG node developers to do this
for you.

@carbolymer carbolymer force-pushed the mgalazyn/fix/remove-timeout-from-test branch from 63ae405 to 66566d6 Compare February 20, 2024 11:31
@carbolymer carbolymer changed the title Remove timeout from InfoAction test Make sure epoch length equation is satisfied for testnet Feb 20, 2024
@smelc
Copy link
Contributor

smelc commented Feb 20, 2024

Looks like the usual timeouts on Mac. Seems fine to be admin-merged to me.

@carbolymer carbolymer force-pushed the mgalazyn/fix/remove-timeout-from-test branch from 66566d6 to 4cac525 Compare February 22, 2024 11:46
@catch-21
Copy link
Contributor

catch-21 commented Feb 22, 2024

I am fairly sure these timeouts are occuring on some tests due to the network existing for longer from genesis with an unstable configuration. This can result in frequent rollbacks, which results in expected transactions not existing on the chain being queried.

Pre-8.8 I was able to run a stable private Conway network with short epoch length of 20 seconds using but I'm unable to find a configuration to make this possible. I don't know why this is but I suspect it to be either a change with consensus or how cardano-testnet is now configured by default. Although, to my knowledge, the only shelley-genesis configuration parameters that impact this is are epochLength, activeSlotsCoeff and securityParam, which must satisfy the rule: Epoch length should be "10 * k / f" where "k = securityParam, f = activeSlotsCoeff". From my experience, an inbalance here can cause instability in longer running chains, which seem to affect longer tests on the Macs in CI more often due to their slower test execution, although I also see it on longer tests on the Linux build machines and more local machine.
Currently, with 8..8 I have managed a stable short-ish epoch length of 100 seconds using activeSlotsCoeff=0.1 and securityParam=10. Will attempt to reduce this further today.

@carbolymer carbolymer force-pushed the mgalazyn/fix/remove-timeout-from-test branch 2 times, most recently from 4ab01e7 to 95b87c2 Compare February 26, 2024 09:16
@carbolymer carbolymer marked this pull request as draft February 28, 2024 16:37
@carbolymer carbolymer force-pushed the mgalazyn/fix/remove-timeout-from-test branch from 95b87c2 to 8bd41f0 Compare February 28, 2024 16:44

This comment was marked as off-topic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants