Various CI fixes #428
Merged
Various CI fixes #428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is usually what you want and ensures that CI will build things.
|
I got stuck trying to work out the correct definition of |
|
@michaelpj No worries. I'll implement a fix for the benchmarks right now. I'll push a commit to your branch, if you don't mind. |
|
Please do :) |
|
@michaelpj Cool. Benchmarks are fixed. Thank you for your help! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't know how to fix the benchmark failure. I think the issue was introduced in 39859fd, so perhaps @tdammers can comment.
Fixes #427