Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect lower bound on io-classes and bump up the version. #426

Merged
merged 1 commit into from
Jul 26, 2023

Conversation

lehins
Copy link
Collaborator

@lehins lehins commented Jul 17, 2023

Lower bound was missing for io-classes and flakes was outdated, which resulted an older version being picked, which in turn resulted in a build error.

This PR fixes this problem

src/Test/Crypto/Util.hs:133:1: error:
    Could not find module ‘Control.Concurrent.Class.MonadMVar’
    Perhaps you meant
      Control.Concurrent.Class.MonadSTM (from io-classes-1.0.0.1)
      Control.Concurrent.Class.MonadSTM.TVar (from io-classes-1.0.0.1)
      Control.Concurrent.Class.MonadSTM.TMVar (from io-classes-1.0.0.1)
    Use -v (or `:set -v` in ghci) to see a list of the files searched for.
    |
133 | import Control.Concurrent.Class.MonadMVar (MVar, withMVar, newMVar)
    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Error: cabal: Failed to build cardano-crypto-tests-2.2.0.0.

@michaelpj
Copy link
Contributor

BTW Hydra CI seems to be showing up a genuine compilation failure in mempool-bench. Is the GHA CI building without benchmarks enabled?

@lehins lehins merged commit 35cd5cf into master Jul 26, 2023
12 checks passed
@lehins lehins deleted the lehins/fix-lower-bound-update-flake branch July 26, 2023 14:31
@lehins
Copy link
Collaborator Author

lehins commented Jul 26, 2023

Is the GHA CI building without benchmarks enabled?

Yeah, sounds like it. @jorisdral just pointed out the same: #418 (comment)

@lehins
Copy link
Collaborator Author

lehins commented Jul 26, 2023

Opened a ticket about benchmarks: #427

@michaelpj
Copy link
Contributor

I'm just gonna fix it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants