Assignments embedded in if-condition are not a good idea.

Interlisp · Nov 13, 2023 · 4247731 · 4247731
1 parent 6cea8c6
commit 4247731
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/src/dir.c b/src/dir.c
@@ -2150,7 +2150,8 @@ LispPTR COM_next_file(LispPTR *args)
   propp = gfsp->propp;
 
   dfp = &FinfoArray[finfoid];
-  if (dfp->head == (FINFO *)0 || (fp = dfp->next) == (FINFO *)0) return (SMALLP_MINUSONE);
+  fp = dfp->next;
+  if (dfp->head == NULL || fp == NULL) return (SMALLP_MINUSONE);
   dfp->next = fp->next;
 
   laddr = gfsp->name;