Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes issues raising from multiple robot instances in a single process #60

Merged
merged 4 commits into from
Feb 22, 2024

Conversation

patilunmesh
Copy link

This pull request updates arm.py file to account for multiple instance of robots in a single process.
A node_owner flag is added to limit access to rclpy states and node executor related functions.
An optional update_kinematics flag is added to save computations by skipping forward kinematics updates.

@patilunmesh patilunmesh changed the title Fixes issues raising from multiple instances of robots in a single process Fixes issues raising from multiple robot instances in a single process Feb 22, 2024
Copy link
Member

@lukeschmitt-tr lukeschmitt-tr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some small changes and nits.

Copy link
Member

@lukeschmitt-tr lukeschmitt-tr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved pending passing CI

@patilunmesh patilunmesh merged commit f6654e8 into humble Feb 22, 2024
1 check passed
@lukeschmitt-tr lukeschmitt-tr deleted the multi-init-bug-fix branch February 26, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants