-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DDS changes and fixes #13386
base: development
Are you sure you want to change the base?
DDS changes and fixes #13386
Changes from all commits
cd82a9c
53dab1b
c6ffc22
4d63b32
56893ab
a188c13
7ed6511
5f16421
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -12,7 +12,7 @@ | |
#define _FAST_DDS_GENERATED_STD_MSGS_MSG_TIME_H_ | ||
|
||
|
||
#include <fastrtps/utils/fixed_size_string.hpp> | ||
//#include <fastrtps/utils/fixed_size_string.hpp> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Was this line something we added or was it downloaded from the net like this? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I've done it elsewhere and this file is not expected to change. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please restore. I don't want to touch third-party files. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. As discussed offline: |
||
|
||
#include <stdint.h> | ||
#include <array> | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This improves ROS compatibility? Were there image formats that were not supported before?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This does not affect compatibility. Or maybe I misunderstand?