hw reset errors handling #13254
Open
hw reset errors handling #13254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nir-Az
reviewed
Aug 13, 2024
| return; // happens when no error occurs | ||
|
|
||
| auto hwm_ans = *reinterpret_cast<hwmon_response*>(res.data()); | ||
| if (hwm_ans == hwmon_response::hwm_Success) |
There was a problem hiding this comment.
So some D500 devices will return 0 data and some success opcode?
We need to ask FW team to align this behavior
both should return success IMO
Nir-Az
reviewed
Aug 13, 2024
| int retries = 0; | ||
| bool success = false; | ||
| const int ERR_SWNotReady = -21; | ||
| const int ERR_Operation_Timeout = -18; |
There was a problem hiding this comment.
What do we do with this error?
|
Any update here? |
Yes - please see info in the ticket :-) |
Nir-Az
reviewed
Sep 1, 2024
|
|
||
| auto hwm_ans = *reinterpret_cast<hwmon_response*>(res.data()); | ||
| if (hwm_ans == hwmon_response::hwm_Success) | ||
| success = true; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracked by: RSDEV-2335