Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GHA - Remove Foxy (EOL) and Galactic (EOL), add Iron (New Distro) #11953

Merged
merged 4 commits into from
Jul 30, 2023
Merged

GHA - Remove Foxy (EOL) and Galactic (EOL), add Iron (New Distro) #11953

merged 4 commits into from
Jul 30, 2023

Conversation

SamerKhshiboun
Copy link
Contributor

@SamerKhshiboun SamerKhshiboun commented Jun 29, 2023 •
edited
Loading

  • Update ROS2 build of librealsense CI to support new distro (Iron), and remove EOL distros (Foxy, Galactic)
  • Update action-ros-ci tool to latest release (v0.3) which supports iron
  • Update setup-ros to latest (v0.7) which supports iron

@SamerKhshiboun SamerKhshiboun reopened this Jul 3, 2023
@Nir-Az Nir-Az closed this Jul 19, 2023
@Nir-Az Nir-Az reopened this Jul 19, 2023
@Nir-Az
Copy link
Collaborator

Nir-Az commented Jul 19, 2023

Clesed & reopened to trigger CI.
Looks like a good PR

@SamerKhshiboun SamerKhshiboun marked this pull request as ready for review July 30, 2023 08:31
@SamerKhshiboun
Copy link
Contributor Author

@Nir-Az, as I asked @maloel, DDS test still not stable on GHA.
Both failures are on DDS tests.
I think we can merge.

Nir-Az
Nir-Az approved these changes Jul 30, 2023
View reviewed changes
Copy link
Collaborator

@Nir-Az Nir-Az left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Nir-Az Nir-Az merged commit d6dfcbc into IntelRealSense:development Jul 30, 2023
14 of 15 checks passed
@MartyG-RealSense MartyG-RealSense mentioned this pull request Aug 22, 2023
Closed
@SamerKhshiboun SamerKhshiboun deleted the patch-2 branch June 8, 2024 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Nir-Az Nir-Az Nir-Az approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SamerKhshiboun @Nir-Az