This repository has been archived by the owner on May 17, 2023. It is now read-only.
Ignore av1 reserved units #2965
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you please share what issue is hit if no this fix? Thanks. |
|
The issue I found while doing android cts. Some test videos contains reserved obu type, and the MSDK returned UMC::UMC_ERR_NOT_IMPLEMENTED. According to the av1-spec, we should ignore it and continue to process. |
|
@zhangyichix I cannot find section 6.2.6 from your spec URL. Do you mean section 6.3? |
|
@wangyan-intel sorry, it is 6.2.2. OBU header semantics. |
wangyan-intel
suggested changes
Jul 20, 2022
| @@ -88,6 +88,11 @@ namespace UMC_AV1_DECODER | |||
| info.num_ticks_per_picture_minus_1 = read_uvlc(bs); | |||
| } | |||
|
|
|||
| inline bool av1_obu_type_is_reserved(AV1_OBU_TYPE& obu_type) | |||
| { | |||
| return 0 == obu_type || (9 <= obu_type && 14 >= obu_type); | |||
There was a problem hiding this comment.
Please use Enum element instead of hard code number.
wangyan-intel
approved these changes
Jul 21, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some av1 videos may contain reserved units. We should ignore it instead of returning an error.
Reference source:
https://aomediacodec.github.io/av1-spec/av1-spec.pdf
Section 6.2.2: Reserved units are for future use and shall be ignored by AV1 decoder.