Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Launcher + S3 overhaul #827

Draft
wants to merge 102 commits into
base: main
Choose a base branch
from
Draft

Launcher + S3 overhaul #827

wants to merge 102 commits into from

Conversation

garronej
Copy link
Contributor

@garronej garronej commented Jul 2, 2024 •
edited
Loading

CF: #802

But this PR covers much more than just this

@garronej garronej marked this pull request as draft July 2, 2024 10:46
@garronej garronej changed the title Launcher overhaul checkpoint Launcher + S3 overhaul Jul 11, 2024
@garronej
Fix readability issues
d110a7e
@garronej
Initialize default s3 config for xOnyxia and explorer
35eaf1c
@garronej
Reimplementation of the thunks of the launcher
716d488
@garronej
Update stufs related to duckdb wasm
087008b
@garronej
Update file explorer to reflect recent change on s3 config managment
0e60aca
@garronej
Update s3 config creation usecase
b8ec5c5
@garronej
update project updateConfigValue() thunk
c3edecc
@garronej
Simplify resolveXOnyxiaValueReference
7efb6dc
@garronej
Only reference xOnyxia context values in overwriteDefaultWith and ove…
d30a7fc 
…rwriteListEnumWith
@garronej
Implement getHelmValues_default
f666c95
@garronej
Add unit tests for values resolution from schema
b3bb81f
@garronej
Add minimal unit test setup
65c94ad
@garronej
Complete launcher thunks
1bdca5d
@garronej
Validation of individual fields is up to the UI, the values should al…
c57424b 
…ways be valid according to the schema
@garronej
Add tests for getValuesAtPath in object and type so that it supports …
628ee15 
…arrays
@garronej
Correctly initialize arrays
66255e4
@garronej
Complete mergeRangeSliders
2e22e9e
@garronej
Complete mergeRangeSliders
b7d472f
@garronej
Introduce Vitest
5d806ca
@garronej
Add test for removeFormFieldGroupWithNoChildren
4530c4d
@garronej
Implemet all helm value mutation for adding and removing array values
948d85e
@garronej
Add tests for mutateHelmValues_addArrayItem
263c029
@garronej
Add test for mutateHelmValues_removeArrayItem
654d4dc
@garronej
Remove unused state in launcher$
1d8c17e
@garronej
Implement mutateHelmValues_update
1bf6664
@garronej
findInRootForm
783a56e
@garronej
Add test for mutateHelmValues_update
0837f7c
@garronej
Complete tests for mutateHelmValues_update
13d046e
@garronej
Externalize createObjectWithSomePropertiesThatThrowIfAccessed
b9c1c33
@garronej
Refactor s3CodeSnippets
b61b102
@garronej
Fix k8sCodeSnippets
7f39b8b
@garronej
Fix viewQuotas
e971033
@garronej
Fix serviceManagement
5a4f3a8
@garronej
current project now in protected selectors
5e825c5
@garronej
Rename utils -> decoupledLogic
44ac0c2
@garronej
Fix restorableConfigManagement
774703f
@garronej
Fix las compile error in the core
87bf495
@garronej
Fix merge conflicts
7d7b73c
@garronej
Refactor #838
fc4be60
@garronej
Update launcher link from MyServices page
0425a81
@garronej
Update ProjectSettings according to refactor
9af7e7b
@garronej
Add testS3Connection and deleteS3Config thunks
6bdfae4
@garronej
Rework s3config creating and deletion
04cea08
@garronej
Add changeIsDefault to s3ConfigManagment
2c5dd27
@garronej garronej mentioned this pull request Sep 18, 2024
Open
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 21, 2024

Quality Gate Passed Quality Gate passed

Issues
146 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
4.6% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@garronej